From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755708AbbCLUZc (ORCPT ); Thu, 12 Mar 2015 16:25:32 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:33670 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752140AbbCLUZZ (ORCPT ); Thu, 12 Mar 2015 16:25:25 -0400 Date: Thu, 12 Mar 2015 16:24:08 -0400 From: Bob Copeland To: Sasha Levin Cc: linux-kernel@vger.kernel.org, "open list:OMFS FILESYSTEM" Subject: Re: [PATCH] fs, omfs: add NULL terminator in the end up the token list Message-ID: <20150312202408.GF9840@localhost> References: <1426191071-765-1-git-send-email-sasha.levin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426191071-765-1-git-send-email-sasha.levin@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 04:11:09PM -0400, Sasha Levin wrote: > match_token() expects a NULL terminator at the end of the token list so that > it would know where to stop. Not having one causes it to overrun to invalid > memory. > > In practice, passing a mount option that omfs didn't recognize would sometimes > panic the system. Yikes, thanks for the catch! Acked-by: Bob Copeland > Signed-off-by: Sasha Levin -- Bob Copeland %% http://bobcopeland.com/