From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756013AbbCLWsB (ORCPT ); Thu, 12 Mar 2015 18:48:01 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:41686 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbbCLWr5 (ORCPT ); Thu, 12 Mar 2015 18:47:57 -0400 Date: Thu, 12 Mar 2015 22:47:54 +0000 From: Matt Fleming To: Andy Lutomirski Cc: Peter Jones , "Kweh, Hock Leong" , Sam Protsenko , Ming Lei , Greg Kroah-Hartman , "Ong, Boon Leong" , LKML , "linux-efi@vger.kernel.org" Subject: Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface Message-ID: <20150312224754.GD24174@codeblueprint.co.uk> References: <20150306213912.GA8020@fenchurch.internal.datastacks.com> <20150310122652.GA17573@codeblueprint.co.uk> <20150310152155.GB1208@fenchurch.internal.datastacks.com> <20150310154000.GD1208@fenchurch.internal.datastacks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Mar, at 08:51:59AM, Andy Lutomirski wrote: > > I'm not 100% happy with write(2) (which is all we have in sysfs) for > two reasons: > > 1. If we write a file name, eww. That's more complicated, requires > temporary files, has annoying mount namespace issues, etc. > > 2. If we write the full contents, we need to do it in a single call to > write. That means that we can't use cat, which mostly defeats the > purpose. In fact, using cat could be actively harmful. At this point I'd really like Greg to chime in. In principal, I'm not stricly opposed to using a simple char device provided that it's not essentially a copy and paste of code from drivers/base/firmware_class.c. Greg? -- Matt Fleming, Intel Open Source Technology Center