Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

Sergey Senozhatsky
2015-03-13T08:16:30Z

On (03/13/15 16:39), Minchan Kim wrote:
> AFAIK, kernel rule doesn't prefer multi-line for printk string
> because it makes hard to work with grep. Anyway, it's trivial.
> For example, checkpatch will emit
>
> WARNING: quoted string split across lines
>

yes, exactly. that's why I mentioned it in the first place.

well... something like this (a bit ugly, but can do the trick):

pr_warn_once("%d (%s): Attribute %s (and others) will be removed. %s\n"
task_pid_nr(current),
current->comm,
name,
"See zram documentation.");

will resend the patch later today.

> Anyway, I agree with your way.

thanks for review!

-ss