Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes

Minchan Kim
2015-03-13T07:39:19Z

On Fri, Mar 13, 2015 at 10:10:35AM +0900, Sergey Senozhatsky wrote:
> Hi Minchan,
>
> On (03/13/15 08:55), Minchan Kim wrote:
> > How about adding pid, comm? Admin can know which process touches.
> >
>
> ok.
>
> > > struct zram *zram = dev_to_zram(d); \
> > > + \
> > > + deprecated_attr_warn(__stringify(name)); \
> >
> > It just reports once for first-touched stat and miss other stats by ZRAM_ATTR_RO.
> > Of course, you warned "See zram documentation" so he might know about other stats
> > plan, too. If it's your intention, let's make warn more clear.
> >
>
> yes, we have a "go and read docs" warning. documentation explains it in details.
> so I think one warning is enough.
>
> > "Atrribute $s will be removed. Also, there are other stats we will remove
> > in future. See Documentation/blockdev/zram.txt"
> >
>
> I didn't want it to be tooooooooooooooo long (and still don't want).
> "Documentation/blockdev/zram.txt" is not a path which a regular user
> can just copy-paste and use to access the documentation. so I'd prefer
> to keep it as "See zram documentation".

Fair enough. When I google zram documentation, first hit is
https://www.kernel.org/doc/Documentation/blockdev/zram.txt
So, it's enough if google search doesn't change his mind.
Otherwise, we could point out above URL.

>
> How about this? (well, a multi-line string.)

AFAIK, kernel rule doesn't prefer multi-line for printk string
because it makes hard to work with grep. Anyway, it's trivial.
For example, checkpatch will emit

WARNING: quoted string split across lines

Anyway, I agree with your way.

Thanks.
--
Kind regards,
Minchan Kim