From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753841AbbCMIQa (ORCPT ); Fri, 13 Mar 2015 04:16:30 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:46369 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbbCMIQU (ORCPT ); Fri, 13 Mar 2015 04:16:20 -0400 Date: Fri, 13 Mar 2015 17:16:25 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Sergey Senozhatsky , Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 7/7] zram: deprecate zram attrs sysfs nodes Message-ID: <20150313081625.GA410@swordfish> References: <1426171638-18209-1-git-send-email-sergey.senozhatsky@gmail.com> <1426171638-18209-8-git-send-email-sergey.senozhatsky@gmail.com> <20150312235547.GA15607@blaptop> <20150313011035.GA1901@swordfish> <20150313073908.GA9753@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150313073908.GA9753@blaptop> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (03/13/15 16:39), Minchan Kim wrote: > AFAIK, kernel rule doesn't prefer multi-line for printk string > because it makes hard to work with grep. Anyway, it's trivial. > For example, checkpatch will emit > > WARNING: quoted string split across lines > yes, exactly. that's why I mentioned it in the first place. well... something like this (a bit ugly, but can do the trick): pr_warn_once("%d (%s): Attribute %s (and others) will be removed. %s\n" task_pid_nr(current), current->comm, name, "See zram documentation."); will resend the patch later today. > Anyway, I agree with your way. thanks for review! -ss