From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbbCMJaI (ORCPT ); Fri, 13 Mar 2015 05:30:08 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47786 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751886AbbCMJaE (ORCPT ); Fri, 13 Mar 2015 05:30:04 -0400 Date: Fri, 13 Mar 2015 10:27:55 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Kishon Vijay Abraham I , linux-kernel , linux-arm-kernel Subject: Re: [PATCH resend v4] phy: Add driver to support individual USB PHYs on sun9i Message-ID: <20150313092754.GQ5085@lukather> References: <1426154079-423-1-git-send-email-wens@csie.org> <5502858D.2060102@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QnQ62SBZf/0gbjGf" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QnQ62SBZf/0gbjGf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 13, 2015 at 04:24:14PM +0800, Chen-Yu Tsai wrote: > >> + phy->vbus =3D devm_regulator_get_optional(dev, "vbus"); > > > > > > Looks like vbus-supply is not documented in the binding documentation. > > However you can use the phy-supply from the generic binding so that phy= -core > > can handle the regulator enable/disable. >=20 > I'll add this one to the bindings because a) the DTS files using them are > already in Maxime's tree and b) try to keep it similar to phy-usb-sun4i. >=20 > Of course if people think it's OK, I can send a patch changing the DTS > file, which itself is queued for 4.1, and drop all the regulator code > from the phy driver. :) >=20 > Maxime? Sounds like a good plan :) Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --QnQ62SBZf/0gbjGf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVAq2aAAoJEBx+YmzsjxAg45QP/RMqPKiXUoJndvQhw7T3CkW7 5ct0QmvtHsqyA/BhCpoZxDmS+PwICtE8WzbQuMH91Esxj+d+LfMFsXMvHPAQqxmR gcdUm6ojNJOqdDfkG9AtDirNP0N0gvJe6utNzXOZci9So00yKTZLZR3h4gD7F+cK yRKK2DlGx77Y+SqgDvEueRBIK+Ejl57n12ZMGVTmr9By/jzqKmA0+5rD9c2y0K94 tmpWH9jlvxc4s74UGK94PeHftqw7oBFiM+LxwQ4Sz8G7tknnFIVo77Cjvu2Frg26 nt2L1/f+dw7y1JRjcaGJN+/MAkqvg1w/OigF0LjFgCkUsKDIJyFLTJN3UjCeUsyj tcz7b1x6Oj/mnHiQ5Y+wfrVl29Oud5LYPVxlTFe5H6xfkHNzQ7JuphZdpTzSmZGF HjiKXIezmfgD9vNYkTF09AtSLKMq5Y6mN2ovGExqWL4qDutx4Zy4/O/WPxDh0ek9 qewjmNc8OaNOOtW1vJaggsLjf50L3b82q0AFQn+LLLIUsOBoxErgwpfgyP6n7CzQ YPvBd6QClD2GVJKvM45HWigC2s/wGM/X1eJ/6GPMA1vmVtd1cy7+aJ7i0+JaXQIG SDwro8V2WofWfgjSniD+yqGNmwPh+QElR296ErDWufhRoV6lBHfrRxPySTFbTWmH AfMW7Y9pXdy5PeVERgbX =I+it -----END PGP SIGNATURE----- --QnQ62SBZf/0gbjGf--