From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbbCMMYp (ORCPT ); Fri, 13 Mar 2015 08:24:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40548 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbCMMYm (ORCPT ); Fri, 13 Mar 2015 08:24:42 -0400 Date: Fri, 13 Mar 2015 08:24:36 -0400 From: Mike Snitzer To: Sergey Senozhatsky Cc: Ming Lei , Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: block: fully initialize queue in blk_mq_init_allocated_queue Message-ID: <20150313122436.GB7312@redhat.com> References: <1426239050-2528-1-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426239050-2528-1-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13 2015 at 5:30am -0400, Sergey Senozhatsky wrote: > Commit c9e8c91f8a279b87eb0d94b037504ea9fc1bef7c > Author: Mike Snitzer > Date: Tue Mar 10 15:54:41 2015 -0400 > > blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path > > for some reason has moved queue allocation 'q = blk_alloc_queue_node()' > after 'percpu_ref_init(&q->mq_usage_counter...)', so we are doing percpu > init on something that is not a request_queue. > > Further commit 716452cd27b145d611e4399e7cc35df6c943686e > Author: Mike Snitzer > Date: Tue Mar 10 17:20:20 2015 -0400 > > blk-mq: add blk_mq_init_allocated_queue and export > > has introduced abother issue. > In blk_mq_init_queue() we allocate new request_queue: > ... Thanks, but I already fixed these 2 patches and pushed them to linux-dm.git's for-next branch last night (I also posted v3 of the corresponding patches to LKML at that time). Sorry to waste your time, I've learned my lesson: Don't validate a tree works and then decide to hurridly rebase before pushing to linux-next, to get a fix before a feature, without re-testing the result (prior to rebase, patches 1 and 2 were inverted and I didn't have the extra blk_mq_init_queue -- that snuck in with the rebase). Hopefully linux-next was able to pick up my new 'for-next' and we don't have an entire weekend of linux-next crashes due to my idiocy.