From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755956AbbCMOrZ (ORCPT ); Fri, 13 Mar 2015 10:47:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40723 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755854AbbCMOrW (ORCPT ); Fri, 13 Mar 2015 10:47:22 -0400 Date: Fri, 13 Mar 2015 09:25:02 -0300 From: Marcelo Tosatti To: Wincy Van Cc: bsd@redhat.com, pbonzini@redhat.com, gleb@kernel.org, yang.z.zhang@intel.com, wanpeng.li@linux.intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jan.kiszka@web.de, yong.y.wang@linux.intel.com Subject: Re: [PATCH v2] KVM: vmx: Set msr bitmap correctly if vcpu is in guest mode Message-ID: <20150313122502.GA11309@amt.cnet> References: <1425450716-2216-1-git-send-email-fanwenyi0529@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425450716-2216-1-git-send-email-fanwenyi0529@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 02:31:56PM +0800, Wincy Van wrote: > In commit 3af18d9c5fe9 ("KVM: nVMX: Prepare for using hardware MSR bitmap"), > we are setting MSR_BITMAP in prepare_vmcs02 if we should use hardware. This > is not enough since the field will be modified by following vmx_set_efer. > > Fix this by setting vmx_msr_bitmap_nested in vmx_set_msr_bitmap if vcpu is > in guest mode. > > Signed-off-by: Wincy Van Applied, thanks.