From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754127AbbCMMbW (ORCPT ); Fri, 13 Mar 2015 08:31:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37610 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbbCMMbV (ORCPT ); Fri, 13 Mar 2015 08:31:21 -0400 Date: Fri, 13 Mar 2015 08:31:15 -0400 From: Mike Snitzer To: Guenter Roeck Cc: "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ming Lei Subject: Re: arm64 crash in today's next due to 'blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path' Message-ID: <20150313123114.GC7312@redhat.com> References: <5502B072.4080108@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5502B072.4080108@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13 2015 at 5:40am -0400, Guenter Roeck wrote: > I see an arm64 crash in today's -next. > > [] blk_mq_freeze_queue_start+0x38/0x54 > [] blk_mq_update_tag_set_depth+0x2c/0xb8 > [] blk_mq_init_allocated_queue+0x6e4/0x71c > [] blk_mq_init_queue+0x2c/0x6c > [] loop_add+0xc0/0x24c > [] loop_init+0x134/0x190 > [] do_one_initcall+0x88/0x1a8 > [] kernel_init_freeable+0x140/0x1e8 > [] kernel_init+0xc/0xdc > > See http://server.roeck-us.net:8010/builders/qemu-arm64-next/builds/132/steps/qemubuildcommand/logs/stdio > for a complete log. > > Bisect results: > ... > # first bad commit: [c9e8c91f8a279b87eb0d94b037504ea9fc1bef7c] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path > > Looking into the patch, this is not surprising, since 'q' is now used before it is allocated. Yes, sorry about this. Certainly embarrassing, please see: https://lkml.org/lkml/2015/3/13/299