From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbbCMM6H (ORCPT ); Fri, 13 Mar 2015 08:58:07 -0400 Received: from mail.us.es ([193.147.175.20]:43862 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbbCMM6F (ORCPT ); Fri, 13 Mar 2015 08:58:05 -0400 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus2 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.6/20189. spamassassin: 3.4.0. Clear:RC:1(127.0.0.1):SA:0(-103.2/7.5):. Processed in 1.927305 secs); 13 Mar 2015 12:58:03 -0000 X-Spam-ASN: AS12715 87.216.0.0/16 X-Envelope-From: pneira@us.es Date: Fri, 13 Mar 2015 14:01:55 +0100 From: Pablo Neira Ayuso To: Richard Weinberger Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com, aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org, davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net Subject: Re: [PATCH 3/4] netfilter: Fix portid types Message-ID: <20150313130155.GA1044@salvia> References: <1426246276-15839-1-git-send-email-richard@nod.at> <1426246276-15839-4-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426246276-15839-4-git-send-email-richard@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 12:31:15PM +0100, Richard Weinberger wrote: > The netlink portid is an unsigned integer, use this type > also in netfilter. This small cleanup I can still take it but... > Signed-off-by: Richard Weinberger > --- > net/netfilter/nfnetlink_log.c | 4 ++-- > net/netfilter/nfnetlink_queue_core.c | 7 ++++--- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c > index 11d85b3..7f00846 100644 > --- a/net/netfilter/nfnetlink_log.c > +++ b/net/netfilter/nfnetlink_log.c > @@ -62,7 +62,7 @@ struct nfulnl_instance { > struct timer_list timer; > struct net *net; > struct user_namespace *peer_user_ns; /* User namespace of the peer process */ > - int peer_portid; /* PORTID of the peer process */ > + unsigned int peer_portid; /* PORTID of the peer process */ I think you have to use u32 for consistency. Other spots use the datatype for the netlink portid. I think same thing applies to other patches.