From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754482AbbCMNNs (ORCPT ); Fri, 13 Mar 2015 09:13:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753659AbbCMNNq (ORCPT ); Fri, 13 Mar 2015 09:13:46 -0400 Date: Fri, 13 Mar 2015 09:13:24 -0400 From: Vivek Goyal To: Borislav Petkov Cc: LKML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton Subject: Re: [PATCH] x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text Message-ID: <20150313131324.GA21790@redhat.com> References: <1426251877-11415-1-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426251877-11415-1-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 02:04:37PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Make it much simpler without losing the gist of what it says. > > Signed-off-by: Borislav Petkov > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Andrew Morton > Cc: Vivek Goyal > --- > arch/x86/Kconfig | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 8f829ffb9003..8db84b0e5bbd 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1775,14 +1775,11 @@ config KEXEC_VERIFY_SIG > depends on KEXEC_FILE > ---help--- > This option makes kernel signature verification mandatory for > - kexec_file_load() syscall. If kernel is signature can not be > - verified, kexec_file_load() will fail. > - > - This option enforces signature verification at generic level. > - One needs to enable signature verification for type of kernel > - image being loaded to make sure it works. For example, enable > - bzImage signature verification option to be able to load and > - verify signatures of bzImage. Otherwise kernel loading will fail. > + the kexec_file_load() syscall. > + > + In addition to that option, you need to enable signature > + verification for the corresponding kernel image type being > + loaded in order for this to work. > Hmm..., I find even previous text to be just fine. But as I wrote it, I might be biased. So I will leave it to others to decide. Thanks Vivek