From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754483AbbCMNnD (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Mar 2015 09:43:03 -0400
Received: from mail-pa0-f46.google.com ([209.85.220.46]:36036 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750769AbbCMNm7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Mar 2015 09:42:59 -0400
Date: Fri, 13 Mar 2015 21:42:14 +0800
From: Shawn Guo <shawn.guo@linaro.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
        Quentin Lambert <lambert.quentin@gmail.com>,
        Mike Turquette <mturquette@linaro.org>,
        Julia Lawall <julia.lawall@lip6.fr>, Paul Walmsley <paul@pwsan.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org,
        t-kristo@ti.com, linux-omap@vger.kernel.org, cocci@systeme.lip6.fr,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct
 clk instances
Message-ID: <20150313134211.GV20455@dragon>
References: <20150202225036.421.43421@quantum>
 <54D0F179.1040906@gmail.com>
 <54D2AA9B.7010800@codeaurora.org>
 <54D3900A.9060200@gmail.com>
 <54D423C3.9030105@codeaurora.org>
 <54E3BA20.3080205@codeaurora.org>
 <20150312172006.GA18418@breakpoint.cc>
 <5501EC6C.5010100@codeaurora.org>
 <20150313032931.GO20455@dragon>
 <20150313082010.GA1033@breakpoint.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150313082010.GA1033@breakpoint.cc>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 13, 2015 at 09:20:10AM +0100, Sebastian Andrzej Siewior wrote:
> Hi Shawn,
> 
> On Fri, Mar 13, 2015 at 11:29:32AM +0800, Shawn Guo wrote:
> 
> > We did not add a DT property for it, because there was already enough
> > info (clock configuration) in DT for kernel to figure it out.
> Correct. My understanding is whatever can be figured out without DT should
> be done that way.
> 
> Is there a way to get this clock-select bit set without
> enable_fec_anatop_clock() in u-boot? Because this one selects the clock and
> frequency and also sets the proper bit in gpr1. My question is simply why do
> we need to do this here as well.

I'm not sure I follow your question.  But we had been doing this setup
in kernel function imx6q_1588_init() for a while.  The problem we're
having now is that the clk core change broke it since v4.0-rc1.  And the
fix is already queued there [1].

Shawn

[1] https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/log/?h=clk-fixes