From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754333AbbCMNts (ORCPT ); Fri, 13 Mar 2015 09:49:48 -0400 Received: from mail.us.es ([193.147.175.20]:38662 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754165AbbCMNtm (ORCPT ); Fri, 13 Mar 2015 09:49:42 -0400 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus3 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.6/20189. spamassassin: 3.4.0. Clear:RC:1(127.0.0.1):SA:0(-103.2/7.5):. Processed in 4.932497 secs); 13 Mar 2015 13:49:41 -0000 X-Spam-ASN: AS12715 87.216.0.0/16 X-Envelope-From: pneira@us.es Date: Fri, 13 Mar 2015 14:53:29 +0100 From: Pablo Neira Ayuso To: Richard Weinberger Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com, aloisio.almeida@openbossa.org, lauro.venancio@openbossa.org, davem@davemloft.net, kadlec@blackhole.kfki.hu, kaber@trash.net Subject: Re: [PATCH 4/4] netfilter: Fix format string of nfnetlink_queue proc file Message-ID: <20150313135329.GA6054@salvia> References: <1426246276-15839-1-git-send-email-richard@nod.at> <1426246276-15839-5-git-send-email-richard@nod.at> <20150313121539.GA14488@salvia> <5502E99A.2060901@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5502E99A.2060901@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 02:43:54PM +0100, Richard Weinberger wrote: > Am 13.03.2015 um 13:15 schrieb Pablo Neira Ayuso: > > On Fri, Mar 13, 2015 at 12:31:16PM +0100, Richard Weinberger wrote: > >> The printed values are all of type unsigned integer, therefore use > >> %u instead of %d. Otherwise an user can face negative values. > >> > >> Fixes: > >> $ cat /proc/net/netfilter/nfnetlink_queue > >> 0 29508 278 2 65531 0 2004213241 -2129885586 1 > >> 1 -27747 0 2 65531 0 0 0 1 > >> 2 -27748 0 2 65531 0 0 0 1 > > > > I guess you want to access stats on dropped packets. > > Correct. :) > > > I prefer if you extend nfnetlink_queue to provide statistics through > > nfnetlink_queue, so you don't have to manually parse this text-based > > /proc entry and we can deprecate this interface. That shouldn't have > > been there in first place. > > You mean statistics via netlink attributes? I can add that! Add a new NFQNL_CFG_CMD_STATS command to request the statistics. If NLM_F_DUMP is set, then we'll basically provide the full list of instances. Otherwise, in case you want to retrieve stats for a specific netlink socket, you can use the netlink portID as index. And you'll have to add attributes for this new command, yes. > But I think we should also fix the format string of the proc file > as the fix is easy and non-intrusive. Unfortunately we don't know how many people are relying on that output, I prefer to remain conservative and provide a proper netlink interface for this.