From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756205AbbCMOwM (ORCPT ); Fri, 13 Mar 2015 10:52:12 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:60732 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbCMOwI (ORCPT ); Fri, 13 Mar 2015 10:52:08 -0400 Date: Fri, 13 Mar 2015 15:48:40 +0100 From: Andrew Lunn To: Russell King - ARM Linux Cc: Ameen Ali , jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 7/7] common.c:105 Variable 'gephy' is never used. Message-ID: <20150313144840.GA7311@lunn.ch> References: <1426254264-5105-1-git-send-email-ameenali023@gmail.com> <20150313141926.GM8656@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150313141926.GM8656@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 02:19:26PM +0000, Russell King - ARM Linux wrote: > On Fri, Mar 13, 2015 at 03:44:24PM +0200, Ameen Ali wrote: > > Variable 'gephy' is assigned a value that is never used. > > > > Signed-off-by : > > --- > > arch/arm/mach-dove/common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c > > index 0d1a892..115a413 100644 > > --- a/arch/arm/mach-dove/common.c > > +++ b/arch/arm/mach-dove/common.c > > @@ -113,7 +113,7 @@ static void __init dove_clk_init(void) > > orion_clkdev_add(NULL, "orion_spi.1", tclk); > > orion_clkdev_add(NULL, "orion_wdt", tclk); > > orion_clkdev_add(NULL, "mv64xxx_i2c.0", tclk); > > - > > + orion_clkdev_add(NULL,"mv643xx_eth_port.0",gephy); > > NAK. Just because some variable isn't read doesn't mean that you need > to dream up some way to make it used. > > In any case, this is wrong because it will duplicate this entry: > > > orion_clkdev_add(NULL, "mv643xx_eth_port.0", ge); Hi Russell Missed that. Sorry. What happens in the DT world is that ge clock is a child of the gephy clock, so that when you enable the ge clock, it walks up towards the parent and enables the gephy clock. I don't see anything like this in the legacy Dove world. Are you just relying on the bootloader turning on the phy and nothing turning it off? Andrew