From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756743AbbCMPeT (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Mar 2015 11:34:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34067 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751732AbbCMPeQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Mar 2015 11:34:16 -0400
Date: Fri, 13 Mar 2015 16:31:55 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Andi Kleen <andi@firstfloor.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Al Viro <viro@zeniv.linux.org.uk>,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3 0/2] x86_64: Sigcontext improvements
Message-ID: <20150313153155.GA23861@redhat.com>
References: <cover.1426193719.git.luto@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1426193719.git.luto@kernel.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/12, Andy Lutomirski wrote:
>
> Patch 1 is IMO a bug fix.

And personally I agree.

I am still not sure about renames in include/uapi, perhaps someone can
ack comment this change...

Perhaps we could could even do

	-	__u16 __pad0;
	+	// comment to explain that ->ss is used starting from 4.x,
	+	// __pad0 is still here to not break userspace.
	+	union { __u16 __pad0; __u16 ss; }

But this is purely cosmetic, and I simply do not know if we should worry
about the potential compilation failure.

I believe both patches are good.

Reviewed-by: Oleg Nesterov <oleg@redhat.com>