Re: [PATCH 0/2] avoid prepare_creds in faccessat when possible

Mateusz Guzik
2015-03-13T12:08:28Z

On Mon, Mar 09, 2015 at 09:35:45PM +0100, Mateusz Guzik wrote:
> Sometimes faccessat needs to modify current thread's credentials, but
> calls prepare_creds unconditionally.
>
> However, typically resulting credentials are identical to original ones
> and in that case newcredentials are unnecessary. We can detect this before
> allocating anything.
>
> This patch series adds a helper which allows comparing capability sets and
> modifies faccessat to use it.
>
> Mateusz Guzik (2):
> CAPABILITIES: add cap_isequal helper
> fs: avoid unnecessary prepare_creds in faccessat
>

Can I get some (N)ACKs on this one?

Thanks,
--
Mateusz Guzik