From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964842AbbCMQZw (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Mar 2015 12:25:52 -0400
Received: from foss.arm.com ([217.140.101.70]:52295 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753109AbbCMQZs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Mar 2015 12:25:48 -0400
Date: Fri, 13 Mar 2015 16:25:16 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Kumar Gala <galak@codeaurora.org>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arm@kernel.org" <arm@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "heiko@sntech.de" <heiko@sntech.de>
Subject: Re: [PATCH v4 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and
 evaluation board dts
Message-ID: <20150313162516.GA9603@leverpostej>
References: <1426182985-10425-1-git-send-email-galak@codeaurora.org>
 <20150313105207.GB3592@leverpostej>
 <04AD8E46-277D-4652-88AF-D16538C2AA87@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <04AD8E46-277D-4652-88AF-D16538C2AA87@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 13, 2015 at 03:50:42PM +0000, Kumar Gala wrote:
> 
> On Mar 13, 2015, at 5:52 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> 
> >> +/ {
> >> +	chosen {
> >> +		stdout-path = &blsp1_uart2;
> >> +	};
> > 
> > It would be good if we had the configuration too (see
> > Documentation/devicetree/bindings/chosen.txt), as that avoids any
> > reliance on kernel defaults.
> > 
> > You can refer to an alias, so this could be:
> > 
> > aliases {
> > 	serial0 = &blsp1_uart2;
> > };
> > 
> > chosen {
> > 	stdout-path = "serial0:115200n8";
> > };
> > 
> > ...assuming that 115200n8 is correct for your UART, of course.
> > 
> > 
> > […]
> 
> Where is the code that actually handles this parsing?  I’m not see it
> in early_init_dt_scan_chosen_serial and I don’t believe
> fdt_path_offset does anything special with ‘:'

Take a look at commit 7914a7c5651a5161 ("of: support passing console options with
stdout-path").

Early on of_alias_scan will find the options and in of_console_check
we'll call add_preferred_console as appropriate. That'll be called in
uart_add_one_port.

> I’ll kill off usage of skeleton.dtsi

Cheers.

Mark.