From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755372AbbCNPPE (ORCPT <rfc822;w@1wt.eu>);
	Sat, 14 Mar 2015 11:15:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51921 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752527AbbCNPPA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 14 Mar 2015 11:15:00 -0400
Date: Sat, 14 Mar 2015 16:13:08 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Borislav Petkov <bp@suse.de>
Cc: Dave Hansen <dave.hansen@intel.com>, Ingo Molnar <mingo@kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Pekka Riikonen <priikone@iki.fi>, Rik van Riel <riel@redhat.com>,
        Suresh Siddha <sbsiddha@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        Quentin Casasnovas <quentin.casasnovas@oracle.com>
Subject: [PATCH 0/1] x86/cpu: kill eager_fpu_init_bp()
Message-ID: <20150314151308.GB13029@redhat.com>
References: <54F74F59.5070107@intel.com> <20150313182656.GA8249@redhat.com> <20150314111648.GD3114@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150314111648.GD3114@pd.tnic>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/14, Borislav Petkov wrote:
>
> On Fri, Mar 13, 2015 at 07:26:56PM +0100, Oleg Nesterov wrote:
> > Hello.
> >
> > This patch is "out of order" a bit, but since Borislav mentioned this
> > during review...
> >
> > And I was going to send the 2nd one (below), but it turns out that
> > __init_refok is not discarded? So is there any way to do
> >
> > 	void __init init_function();
> >
> > 	void non_init_func()
> > 	{
> > 		if (can_only_be_true_before_free_initmem)
> > 			init_function();
> > 	}
> >
> > and avoid the warning?

It turns out I _completely_ misunderstood __init_refok.

> Actually, I was wondering if we could be even more radical and do
> the boot cpu-specific stuff only in the BSP boot path.

Yes, yes, agreed. This needs more changes, but imo this would be a nice
cleanup.

Still. I think it makes sense to kill eager_fpu_init_bp() right now, this
won'r complicate the mentioned cleanups.

On top of  "x86/fpu: don't allocate fpu->state for swapper/0".

Oleg.