From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbbCOKuE (ORCPT ); Sun, 15 Mar 2015 06:50:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37784 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbbCOKuC (ORCPT ); Sun, 15 Mar 2015 06:50:02 -0400 Date: Sun, 15 Mar 2015 13:49:47 +0300 From: Dan Carpenter To: MyungJoo Ham Cc: Chanwoo Choi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch 1/2] extcon: max77843: signedness bug in max77843_muic_set_debounce_time() Message-ID: <20150315104947.GD20691@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "ret" holds negative error codes and zero so it should be signed. Fixes: 27a28d32b4f2 ('extcon: max77843: Add max77843 MUIC driver') Signed-off-by: Dan Carpenter diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c index 598a017..a3f80ca 100644 --- a/drivers/extcon/extcon-max77843.c +++ b/drivers/extcon/extcon-max77843.c @@ -682,7 +682,7 @@ static int max77843_muic_set_debounce_time(struct max77843_muic_info *info, enum max77843_muic_adc_debounce_time time) { struct max77843 *max77843 = info->max77843; - unsigned int ret; + int ret; switch (time) { case MAX77843_DEBOUNCE_TIME_5MS: