From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752948AbbCPCLs (ORCPT <rfc822;w@1wt.eu>);
	Sun, 15 Mar 2015 22:11:48 -0400
Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:57361 "EHLO
	lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751684AbbCPCLq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 15 Mar 2015 22:11:46 -0400
X-Original-SENDERIP: 10.177.220.203
X-Original-MAILFROM: namhyung@kernel.org
Date: Mon, 16 Mar 2015 11:06:22 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Minchan Kim <minchan@kernel.org>, Joonsoo Kim <js1304@gmail.com>
Subject: Re: [RFC/PATCHSET 0/6] perf kmem: Implement page allocation analysis
 (v1)
Message-ID: <20150316020622.GP943@sejong>
References: <1426145571-3065-1-git-send-email-namhyung@kernel.org>
 <20150312104119.GA5978@gmail.com>
 <20150312145837.GA1398@danjae>
 <20150312155422.GA9779@gmail.com>
 <20150313081930.GA10836@danjae.skbroadband>
 <20150313124420.GA4261@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150313124420.GA4261@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ingo,

On Fri, Mar 13, 2015 at 01:44:20PM +0100, Ingo Molnar wrote:
> 
> * Namhyung Kim <namhyung@kernel.org> wrote:
> 
> > Hi Ingo,
> > 
> > On Thu, Mar 12, 2015 at 04:54:22PM +0100, Ingo Molnar wrote:
> > > 
> > > * Namhyung Kim <namhyung@kernel.org> wrote:
> > > 
> > > > > I.e. something like this (mockup) output:
> > > > > 
> > > > >    SUMMARY (page allocator)
> > > > >    ========================
> > > > > 
> > > > >    Pages allocated+freed:       12,593   [     51,630,080 bytes ]
> > > > > 
> > > > >    Pages allocated-only:         2,342   [      1,235,010 bytes ]
> > > > >    Pages freed-only:                67   [        135,311 bytes ]
> > > > > 
> > > > >    Page allocation failures :        0
> > > > 
> > > > Looks a lot better!
> > > > 
> > > > One thing I need to tell you is that the numbers are not pages but 
> > > > requests.
> > > 
> > > Yes, but in the MM code we tend to call larger order allocations 
> > > 'pages' as well: higher order pages, such as a 2MB hugepage, or a 8K 
> > > order-1 page. So at least in MM-speak it should be OK to call them 
> > > 'pages'.
> > > 
> > > But your call!
> > 
> > How about this?
> > 
> >   SUMMARY (page allocator)
> >   ========================
> >   Total allocation requests   :        9,015  [     37,200 Kbytes ]  (A)
> >   Total free requests         :        8,093  [     33,176 Kbytes ]  (B)
> > 
> >   Total alloc+freed requests  :        7,985  [     32,732 Kbytes ]  (C)
> >   Total alloc-only requests   :        1,030  [      4,468 Kbytes ]  (D)
> >   Total free-only requests    :          108  [        444 Kbytes ]  (E)
> > 
> >   Total allocation failure    :            0  [          0 Kbytes ]
> 
> s/failure/failures
> s/Kbytes/KB

OK

> 
> I'd leave a bit more space for the numbers, for up into billions of 
> requests and terabytes of data. Other than that, sounds good to me!

I reserved 16 character space for each!

Thanks,
Namhyung