From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbbCPHpv (ORCPT ); Mon, 16 Mar 2015 03:45:51 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:33828 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbbCPHpt (ORCPT ); Mon, 16 Mar 2015 03:45:49 -0400 Date: Mon, 16 Mar 2015 08:45:43 +0100 From: Ingo Molnar To: Yinghai Lu Cc: "H. Peter Anvin" , Ingo Molnar , Kees Cook , Borislav Petkov , Baoquan He , Thomas Gleixner , Jiri Kosina , Andrew Morton , Linus Torvalds , linux-kernel@vger.kernel.org, Matt Fleming Subject: Re: [PATCH v4] x86, boot: Make data from decompress_kernel stage live longer Message-ID: <20150316074543.GA15772@gmail.com> References: <1426405744-21064-1-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426405744-21064-1-git-send-email-yinghai@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > After commit f47233c2d34f ("x86/mm/ASLR: Propagate base load address > calculation"), get warning about setup_data from debugfs for > setup_data. Boris found setup_data for kaslr from boot stage become > all 0's in kernel stage. And? What is the high level effect to the user? 'setup_data for kaslr from boot stage becomes all 0's' is not a high level effect. It's a detail of the mechanism of the bug, not a high level effect. Think of a regular Linux user reading your changelogs. The first paragraph of bug fixes should be readable to them! _That_ is what 'high level' means. Thanks, Ingo