From: Ingo Molnar <mingo@kernel.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: akpm@linux-foundation.org, hpa@zytor.com, tglx@linutronix.de,
mingo@redhat.com, linux-mm@kvack.org, x86@kernel.org,
linux-kernel@vger.kernel.org, dave.hansen@intel.com,
Elliott@hp.com, pebolle@tiscali.nl
Subject: Re: [PATCH v3 2/5] mtrr, x86: Fix MTRR lookup to handle inclusive entry
Date: Mon, 16 Mar 2015 08:49:54 +0100 [thread overview]
Message-ID: <20150316074954.GA15955@gmail.com> (raw)
In-Reply-To: <1426282421-25385-3-git-send-email-toshi.kani@hp.com>
* Toshi Kani <toshi.kani@hp.com> wrote:
> When an MTRR entry is inclusive to a requested range, i.e.
> the start and end of the request are not within the MTRR
> entry range but the range contains the MTRR entry entirely,
> __mtrr_type_lookup() ignores such a case because both
> start_state and end_state are set to zero.
>
> This patch fixes the issue by adding a new flag, 'inclusive',
> to detect the case. This case is then handled in the same
> way as (!start_state && end_state).
It would be nice to discuss the high level effects of this fix in the
changelog: i.e. what (presumably bad thing) happened before the
change, what will happen after the change? What did users experience
before the patch, and what will users experience after the patch?
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-16 7:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 21:33 [PATCH v3 0/5] mtrr, mm, x86: Enhance MTRR checks for huge I/O mapping Toshi Kani
2015-03-13 21:33 ` [PATCH v3 1/5] mm, x86: Document return values of mapping funcs Toshi Kani
2015-03-13 21:33 ` [PATCH v3 2/5] mtrr, x86: Fix MTRR lookup to handle inclusive entry Toshi Kani
2015-03-16 7:49 ` Ingo Molnar [this message]
2015-03-16 21:03 ` Kani, Toshimitsu
2015-03-13 21:33 ` [PATCH v3 3/5] mtrr, x86: Fix MTRR state checks in mtrr_type_lookup() Toshi Kani
2015-03-16 7:51 ` Ingo Molnar
2015-03-16 21:08 ` Kani, Toshimitsu
2015-03-13 21:33 ` [PATCH v3 4/5] mtrr, x86: Clean up mtrr_type_lookup() Toshi Kani
2015-03-16 7:58 ` Ingo Molnar
2015-03-16 21:24 ` Kani, Toshimitsu
2015-03-23 19:27 ` Toshi Kani
2015-03-13 21:33 ` [PATCH v3 5/5] mtrr, mm, x86: Enhance MTRR checks for KVA huge page mapping Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316074954.GA15955@gmail.com \
--to=mingo@kernel.org \
--cc=Elliott@hp.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pebolle@tiscali.nl \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox