From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182AbbCPIoR (ORCPT ); Mon, 16 Mar 2015 04:44:17 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44427 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbbCPIoN (ORCPT ); Mon, 16 Mar 2015 04:44:13 -0400 Date: Mon, 16 Mar 2015 11:44:05 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, joe@perches.com, devel@driverdev.osuosl.org, mdcasey@chabloom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) Message-ID: <20150316084405.GG10964@mwanda> References: <1426059960-11587-1-git-send-email-mateusz.kulikowski@gmail.com> <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 12:53:16AM +0100, Mateusz Kulikowski wrote: > - 'WARNING: break quoted strings at a space character' > @@ -1361,9 +1365,10 @@ static u8 HwRateToMRate90(bool bIsHT, u8 rate) > break; > > default: > - RT_TRACE(COMP_RECV, "HwRateToMRate90(): Non supported" > - "Rate [%x], bIsHT = %d!!!\n", rate, bIsHT); > - break; > + RT_TRACE(COMP_RECV, > + "HwRateToMRate90(): Non supportedRate [%x], bIsHT = %d!!!\n", There should be a space character between "supported" and "Rate". You can fix it in a later patch though, it's minor. And really no one cares about RT_TRACE() output. regards, dan carpenter