From: Dan Carpenter <dan.carpenter@oracle.com>
To: Isaac Lleida <illeida@openaliasbox.org>
Cc: willy@meta-x.org, devel@driverdev.osuosl.org,
armand.bastien@laposte.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, marius.gorski@gmail.com,
domdevlin@free.fr, kernel-janitors-owner@vger.kernel.org,
sudipm.mukherjee@gmail.com
Subject: Re: [PATCH v4] staging: panel: change struct bits to a bit array
Date: Mon, 16 Mar 2015 12:25:31 +0300 [thread overview]
Message-ID: <20150316092531.GI10964@mwanda> (raw)
In-Reply-To: <1426410236-16509-1-git-send-email-illeida@openaliasbox.org>
On Sun, Mar 15, 2015 at 10:03:56AM +0100, Isaac Lleida wrote:
> This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage.
Sudip told you to line wrap the changelog but it's still not wrapped.
Anyway, please step back and rethink the whole approach. It doesn't
save any memory when you consider how variables are stored in memory
(alignment) and it doesn't make the code more readable.
Both "bits.e" and "BIT_CHK(bits, LCD_BIT_E_MASK)" are terrible. The new
one is worse because it takes more words to tell you nothing and because
it is wrong since E is a flag not a mask.
Think about how you can make it more clear.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-16 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 9:03 [PATCH v4] staging: panel: change struct bits to a bit array Isaac Lleida
2015-03-16 9:25 ` Dan Carpenter [this message]
2015-03-17 6:39 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316092531.GI10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=armand.bastien@laposte.net \
--cc=devel@driverdev.osuosl.org \
--cc=domdevlin@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=illeida@openaliasbox.org \
--cc=kernel-janitors-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.gorski@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox