From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbbCPJZ6 (ORCPT ); Mon, 16 Mar 2015 05:25:58 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33217 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399AbbCPJZ4 (ORCPT ); Mon, 16 Mar 2015 05:25:56 -0400 Date: Mon, 16 Mar 2015 12:25:31 +0300 From: Dan Carpenter To: Isaac Lleida Cc: willy@meta-x.org, devel@driverdev.osuosl.org, armand.bastien@laposte.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, marius.gorski@gmail.com, domdevlin@free.fr, kernel-janitors-owner@vger.kernel.org, sudipm.mukherjee@gmail.com Subject: Re: [PATCH v4] staging: panel: change struct bits to a bit array Message-ID: <20150316092531.GI10964@mwanda> References: <1426410236-16509-1-git-send-email-illeida@openaliasbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426410236-16509-1-git-send-email-illeida@openaliasbox.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 15, 2015 at 10:03:56AM +0100, Isaac Lleida wrote: > This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage. Sudip told you to line wrap the changelog but it's still not wrapped. Anyway, please step back and rethink the whole approach. It doesn't save any memory when you consider how variables are stored in memory (alignment) and it doesn't make the code more readable. Both "bits.e" and "BIT_CHK(bits, LCD_BIT_E_MASK)" are terrible. The new one is worse because it takes more words to tell you nothing and because it is wrong since E is a flag not a mask. Think about how you can make it more clear. regards, dan carpenter