Re: [PATCH 4/4] x86/fpu: don't abuse drop_init_fpu() in flush_thread()

Borislav Petkov
2015-03-16T15:27:48Z

On Mon, Mar 16, 2015 at 03:39:44PM +0100, Oleg Nesterov wrote:
> ACK!

Thanks.

> Perhaps you can also find a beter name for __save_init_fpu/etc ;) The
> name clearly suggests that it does "save + init" while in fact it does
> "save and may be destroy FPU state". At least for the callers, the fact
> that "destroy" is actually "init" doesn't really matter.
>
> But lets not rename it right now. This can conflict with the fixes we
> need to do first.

Right, so I think we should do fixes/cleanups first so that we can lose
all the fat/cruft this code has grown. I'll make looking at that code
easier later.

I'll push out everything I have collected so far for people to see after
I've finished bisecting another tip/master regression from today.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--