From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbbCPKVW (ORCPT ); Mon, 16 Mar 2015 06:21:22 -0400 Received: from mx-guillaumet.finsecur.com ([91.217.234.131]:35733 "EHLO guillaumet.finsecur.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbbCPKVT (ORCPT ); Mon, 16 Mar 2015 06:21:19 -0400 Date: Mon, 16 Mar 2015 11:21:12 +0100 From: Sylvain Rochet To: Wenyou Yang Cc: nicolas.ferre@atmel.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, peda@axentia.se, sergei.shtylyov@cogentembedded.com, linux@maxim.org.za Message-ID: <20150316102112.GA29170@gradator.net> References: <1425873378-8253-1-git-send-email-wenyou.yang@atmel.com> <1425873428-8292-1-git-send-email-wenyou.yang@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1425873428-8292-1-git-send-email-wenyou.yang@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 172.16.8.13 X-SA-Exim-Mail-From: sylvain.rochet@finsecur.com Subject: Re: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3 and sama5d4 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on guillaumet.finsecur.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Wenyou, On Mon, Mar 09, 2015 at 11:57:08AM +0800, Wenyou Yang wrote: > To get the mpddrc peripheral id from the PM initialization, > which will be used to disable mpddrc'c clock during suspending. > +void __init sam5d3_pm_init(void) > +{ > + at91_dt_ramc(); > + at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP | AT91SAM926x_PMC_UDP; > + at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR; > + at91_pm_data.ddrc_pid = SAMA5D3_ID_MPDDRC; > + return at91_pm_init(); > +} > + > +void __init sam5d4_pm_init(void) > +{ > + at91_dt_ramc(); > + at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP | AT91SAM926x_PMC_UDP; > + at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR; > + at91_pm_data.ddrc_pid = SAMA5D4_ID_MPDDRC; > + at91_pm_data.is_sama5d4 = true; > + return at91_pm_init(); > +} > +static void __init sama5d4_dt_device_init(void) > +{ > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > + sam5d4_pm_init(); > +} This doesn't look right, where is sam5d3_pm_init() actually used ? Sylvain