From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758147AbbCPPdL (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Mar 2015 11:33:11 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:58980 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756706AbbCPPdG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Mar 2015 11:33:06 -0400
Date: Mon, 16 Mar 2015 16:33:02 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Marek Belisko <marek.belisko@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: ft1000: remove unused variables
Message-ID: <20150316153302.GA12113@kroah.com>
References: <1425706013-8888-1-git-send-email-sudipm.mukherjee@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1425706013-8888-1-git-send-email-sudipm.mukherjee@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote:
> these variables were assigned some values but they were never being
> reused again.

But some of them should have been checked, right?  Or, if no one cares,
fix up the function to not return anything, like for all of the
read_register() calls.

Please do that instead.

thanks,

greg k-h