From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934059AbbCPPdm (ORCPT ); Mon, 16 Mar 2015 11:33:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58990 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757497AbbCPPdi (ORCPT ); Mon, 16 Mar 2015 11:33:38 -0400 Date: Mon, 16 Mar 2015 16:33:34 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Marek Belisko , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: ft1000: remove code indention Message-ID: <20150316153334.GB12113@kroah.com> References: <1425706013-8888-1-git-send-email-sudipm.mukherjee@gmail.com> <1425706013-8888-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425706013-8888-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 07, 2015 at 10:56:53AM +0530, Sudip Mukherjee wrote: > modified the code to keep the logic same but removed some indention. > > Signed-off-by: Sudip Mukherjee > --- > > this patch will generate checkpatch warning about line more than 80char, > and too many use of tab. but unless the total function is rewrtten it will > be difficult to fix that. > > drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 44 +++++++++++------------- > 1 file changed, 21 insertions(+), 23 deletions(-) I don't see how this looks any better, do you?