From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934372AbbCPPfI (ORCPT ); Mon, 16 Mar 2015 11:35:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59061 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932620AbbCPPfB (ORCPT ); Mon, 16 Mar 2015 11:35:01 -0400 Date: Mon, 16 Mar 2015 16:34:58 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Benjamin Romer , David Kershner , sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: unisys: remove unused variables Message-ID: <20150316153458.GA12503@kroah.com> References: <1426169661-15142-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426169661-15142-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 07:44:20PM +0530, Sudip Mukherjee wrote: > these variable were being assigned some values but never reused. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/unisys/virthba/virthba.c | 18 ++++++------------ > drivers/staging/unisys/virtpci/virtpci.c | 22 +++++++--------------- > 2 files changed, 13 insertions(+), 27 deletions(-) > > diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba/virthba.c > index e5b0dd8..655db2f 100644 > --- a/drivers/staging/unisys/virthba/virthba.c > +++ b/drivers/staging/unisys/virthba/virthba.c > @@ -333,16 +333,14 @@ static inline void > send_disk_add_remove(struct diskaddremove *dar) > { > struct scsi_device *sdev; > - int error; > > sdev = scsi_device_lookup(dar->shost, dar->channel, dar->id, dar->lun); > if (sdev) { > if (!(dar->add)) > scsi_remove_device(sdev); > } else if (dar->add) { > - error = > - scsi_add_device(dar->shost, dar->channel, dar->id, > - dar->lun); > + scsi_add_device(dar->shost, dar->channel, dar->id, > + dar->lun); This should be properly checked, not ignored.