From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933264AbbCPRGn (ORCPT ); Mon, 16 Mar 2015 13:06:43 -0400 Received: from mga14.intel.com ([192.55.52.115]:26191 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756949AbbCPRGl (ORCPT ); Mon, 16 Mar 2015 13:06:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,410,1422950400"; d="scan'208";a="699448519" Date: Mon, 16 Mar 2015 22:32:57 +0530 From: Vinod Koul To: Ameen Ali Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset Message-ID: <20150316170257.GW32683@intel.com> References: <1426258514-6001-1-git-send-email-ameenali023@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426258514-6001-1-git-send-email-ameenali023@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 04:55:14PM +0200, Ameen Ali wrote: > The 2nd memset() argument '286331153' doesn't fit into an 'unsigned char'. care to explain hpow it is fixed... > > Signed-off-by : This is not proper, see Documentation/SubmittingPatches > --- > drivers/dma/iop-adma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c > index 263d9f6..78382b0 100644 > --- a/drivers/dma/iop-adma.c > +++ b/drivers/dma/iop-adma.c > @@ -1126,7 +1126,7 @@ iop_adma_pq_zero_sum_self_test(struct iop_adma_device *device) > /* Fill in src buffers */ > for (i = 0; i < IOP_ADMA_NUM_SRC_TEST; i++) { > pq_sw[i] = page_address(pq[i]); > - memset(pq_sw[i], 0x11111111 * (1< + memset(pq_sw[i], 0x11111111 & (1< } > pq_sw[i] = page_address(pq[i]); > pq_sw[i+1] = page_address(pq[i+1]); > -- > 2.1.0 > --