* [PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset
@ 2015-03-13 14:55 Ameen Ali
2015-03-16 17:02 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Ameen Ali @ 2015-03-13 14:55 UTC (permalink / raw)
To: dan.j.williams, vinod.koul; +Cc: dmaengine, linux-kernel, Ameen Ali
The 2nd memset() argument '286331153' doesn't fit into an 'unsigned char'.
Signed-off-by : <AmeenAli023@gmail.com>
---
drivers/dma/iop-adma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c
index 263d9f6..78382b0 100644
--- a/drivers/dma/iop-adma.c
+++ b/drivers/dma/iop-adma.c
@@ -1126,7 +1126,7 @@ iop_adma_pq_zero_sum_self_test(struct iop_adma_device *device)
/* Fill in src buffers */
for (i = 0; i < IOP_ADMA_NUM_SRC_TEST; i++) {
pq_sw[i] = page_address(pq[i]);
- memset(pq_sw[i], 0x11111111 * (1<<i), PAGE_SIZE);
+ memset(pq_sw[i], 0x11111111 & (1<<i), PAGE_SIZE);
}
pq_sw[i] = page_address(pq[i]);
pq_sw[i+1] = page_address(pq[i+1]);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset
2015-03-13 14:55 [PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset Ameen Ali
@ 2015-03-16 17:02 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2015-03-16 17:02 UTC (permalink / raw)
To: Ameen Ali; +Cc: dan.j.williams, dmaengine, linux-kernel
On Fri, Mar 13, 2015 at 04:55:14PM +0200, Ameen Ali wrote:
> The 2nd memset() argument '286331153' doesn't fit into an 'unsigned char'.
care to explain hpow it is fixed...
>
> Signed-off-by : <AmeenAli023@gmail.com>
This is not proper, see Documentation/SubmittingPatches
> ---
> drivers/dma/iop-adma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c
> index 263d9f6..78382b0 100644
> --- a/drivers/dma/iop-adma.c
> +++ b/drivers/dma/iop-adma.c
> @@ -1126,7 +1126,7 @@ iop_adma_pq_zero_sum_self_test(struct iop_adma_device *device)
> /* Fill in src buffers */
> for (i = 0; i < IOP_ADMA_NUM_SRC_TEST; i++) {
> pq_sw[i] = page_address(pq[i]);
> - memset(pq_sw[i], 0x11111111 * (1<<i), PAGE_SIZE);
> + memset(pq_sw[i], 0x11111111 & (1<<i), PAGE_SIZE);
> }
> pq_sw[i] = page_address(pq[i]);
> pq_sw[i+1] = page_address(pq[i+1]);
> --
> 2.1.0
>
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-16 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-13 14:55 [PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset Ameen Ali
2015-03-16 17:02 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox