From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933930AbbCPS2O (ORCPT ); Mon, 16 Mar 2015 14:28:14 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:55796 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933882AbbCPS2L (ORCPT ); Mon, 16 Mar 2015 14:28:11 -0400 Date: Mon, 16 Mar 2015 18:28:09 +0000 From: Charles Keepax To: Mark Brown Cc: lee.jones@linaro.org, sameo@linux.intel.com, lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode Message-ID: <20150316182809.GA23705@opensource.wolfsonmicro.com> References: <1426525124-12317-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1426525124-12317-5-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20150316171755.GV28806@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150316171755.GV28806@sirena.org.uk> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 05:17:55PM +0000, Mark Brown wrote: > On Mon, Mar 16, 2015 at 04:58:44PM +0000, Charles Keepax wrote: > > > + } else { > > + switch (arizona->type) { > > + case WM5110: > > + case WM8280: > > + ret = regulator_set_voltage(arizona->dcvdd, > > + 1175000, 1175000); > > + if (ret < 0) { > > Can we please have a comment about this being the internal LDO and us > therefore knowing exactly what voltages it supports (or just that it's > the on chip LDO)? Going for a single voltage with zero tolerance is > usually bad practice since it causes needless interoperability issues > (eg, here the chances that the hardware would mind if an external > regulator were only able to deliver 1.174V rather than 1.175V are > minimal). This is fine here but people might be looking for examples > and get the wrong idea. Yeah no problem I will respin and add that. Thanks, Charles