Re: [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible

Russell King - ARM Linux
2014-09-05T12:13:52Z

On Fri, Sep 05, 2014 at 01:38:40PM +0200, Pali Rohár wrote:
> On Wednesday 18 June 2014 18:54:24 Pali Rohár wrote:
> > Machine name from board description is some generic name on DT
> > kernel. DT provides machine name property which is specific
> > for board, so use it instead generic one when possible.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
> > arch/arm/kernel/setup.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> > index 8a16ee5..fbc7b4f 100644
> > --- a/arch/arm/kernel/setup.c
> > +++ b/arch/arm/kernel/setup.c
> > @@ -875,10 +875,13 @@ void __init setup_arch(char **cmdline_p)
> >
> > setup_processor();
> > mdesc = setup_machine_fdt(__atags_pointer);
> > - if (!mdesc)
> > + if (mdesc)
> > + machine_name = of_flat_dt_get_machine_name();
> > + else
> > mdesc = setup_machine_tags(__atags_pointer,
> > __machine_arch_type); machine_desc = mdesc;
> > - machine_name = mdesc->name;
> > + if (!machine_name)
> > + machine_name = mdesc->name;
> >
> > if (mdesc->reboot_mode != REBOOT_HARD)
> > reboot_mode = mdesc->reboot_mode;
>
> So, do you really want to break userspace which reading file
> /proc/cpuinfo (after migration from boardcode --> DT)?
>
> I still do not see reason for that. And only this one file is
> problematic...

Sorry, I just don't give a damn about your whinging about this. I've
made the situation perfectly clear. Your patch will not be accepted.

Thanks.

--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.