Re: [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible

Pali Rohár
2014-11-24T22:23:36Z

[-- Attachment #1: Type: Text/Plain, Size: 1579 bytes --]

On Wednesday 10 September 2014 14:46:15 Pavel Machek wrote:
> On Fri 2014-09-05 13:13:16, Russell King - ARM Linux wrote:
> > On Fri, Sep 05, 2014 at 01:38:40PM +0200, Pali Rohár wrote:
> > > On Wednesday 18 June 2014 18:54:24 Pali Rohár wrote:
> > > > - if (!mdesc)
> > > > + if (mdesc)
> > > > + machine_name = of_flat_dt_get_machine_name();
> > > > + else
> > > >
> > > > mdesc = setup_machine_tags(__atags_pointer,
> > > >
> > > > __machine_arch_type); machine_desc = mdesc;
> > > > - machine_name = mdesc->name;
> > > > + if (!machine_name)
> > > > + machine_name = mdesc->name;
> > > >
> > > > if (mdesc->reboot_mode != REBOOT_HARD)
> > > >
> > > > reboot_mode = mdesc->reboot_mode;
> > >
> > > So, do you really want to break userspace which reading
> > > file /proc/cpuinfo (after migration from boardcode -->
> > > DT)?
> > >
> > > I still do not see reason for that. And only this one file
> > > is problematic...
> >
> > Sorry, I just don't give a damn about your whinging about
> > this. I've made the situation perfectly clear. Your patch
> > will not be accepted.
>
> Linus made it pretty clear that regressions are not accepted.
>
> You are an arm maintainer and there is regression in n900 that
> broke userspace.
>
> How do you solve it?
> Pavel

I must agree, it is breaking userspace. Even worse DT booting
does not provide those old information about board which
bootloader set in ATAG info (and which is needed for some
applications).

--
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]