From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932863AbbCPWoa (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Mar 2015 18:44:30 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:34635 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932197AbbCPWo3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Mar 2015 18:44:29 -0400
Date: Mon, 16 Mar 2015 22:44:28 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: NeilBrown <neilb@suse.de>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/13] VFS/namei: enable RCU-walk when following symlinks.
Message-ID: <20150316224428.GF29656@ZenIV.linux.org.uk>
References: <20150316043602.23648.52734.stgit@notabene.brown>
 <20150316044320.23648.43776.stgit@notabene.brown>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150316044320.23648.43776.stgit@notabene.brown>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 16, 2015 at 03:43:20PM +1100, NeilBrown wrote:
>  	if (should_follow_link(path->dentry, follow)) {
> -		if (nd->flags & LOOKUP_RCU) {
> -			if (unlikely(unlazy_walk(nd, path->dentry))) {
> -				err = -ECHILD;
> -				goto out_err;
> -			}
> -		}
>  		BUG_ON(inode != path->dentry->d_inode);

... and now this BUG_ON() can bloody well be triggered.
>  	if (should_follow_link(path->dentry, !symlink_ok)) {
> -		if (nd->flags & LOOKUP_RCU) {
> -			if (unlikely(unlazy_walk(nd, path->dentry))) {
> -				error = -ECHILD;
> -				goto out;
> -			}
> -		}
>  		BUG_ON(inode != path->dentry->d_inode);

So can this.