From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@arm.com>,
linux-kernel@vger.kernel.org,
Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH RESEND v10] sched/deadline: support dl task migration during cpu hotplug
Date: Tue, 17 Mar 2015 07:01:10 +0800 [thread overview]
Message-ID: <20150316230110.GA14994@kernel> (raw)
In-Reply-To: <20150316150101.GA18521@gmail.com>
Hi Ingo,
On Mon, Mar 16, 2015 at 04:01:02PM +0100, Ingo Molnar wrote:
>> +
>> + /*
>> + * If cannot preempt any rq, fallback to pick any
>> + * online cpu.
>
>s/If cannot/If we cannot
>s/fallback/fall back
Will do.
>
>> + */
>> + fallback = true;
>> + cpu = cpumask_any_and(cpu_active_mask,
>> + tsk_cpus_allowed(p));
>
>shouldn't be on separate lines - but this is also a sign that the guts
Otherwise there is a "WARNING: line over 80 characters".
>of this new code should be in a helper function, not inside several
>layers of branches.
Do you mean the whole patch should be in a helper function?
>
>> + if (cpu >= nr_cpu_ids) {
>> + if (dl_bandwidth_enabled()) {
>> + /*
>> + * Fail to find any suitable cpu.
>> + * The task will never come back!
>> + */
>> + WARN_ON(1);
>
>Can this condition happen to users with a non-buggy kernel?
What do you prefer? ;-)
Regards,
Wanpeng Li
next prev parent reply other threads:[~2015-03-16 23:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 7:27 [PATCH RESEND v10] sched/deadline: support dl task migration during cpu hotplug Wanpeng Li
2015-03-16 12:09 ` Wanpeng Li
2015-03-16 15:01 ` Ingo Molnar
2015-03-16 23:01 ` Wanpeng Li [this message]
2015-03-17 8:06 ` Ingo Molnar
2015-03-17 7:53 ` Wanpeng Li
2015-03-17 8:13 ` Ingo Molnar
2015-03-17 7:59 ` Wanpeng Li
2015-03-23 7:25 ` Ingo Molnar
2015-03-23 8:55 ` Peter Zijlstra
2015-03-24 9:27 ` Juri Lelli
2015-03-24 9:13 ` Wanpeng Li
2015-03-24 10:00 ` Juri Lelli
2015-03-24 9:43 ` Wanpeng Li
2015-03-30 9:12 ` Peter Zijlstra
2015-03-31 8:55 ` Juri Lelli
2015-03-24 9:50 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316230110.GA14994@kernel \
--to=wanpeng.li@linux.intel.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).