From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755477AbbCPXe4 (ORCPT ); Mon, 16 Mar 2015 19:34:56 -0400 Received: from muru.com ([72.249.23.125]:37980 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753854AbbCPXez (ORCPT ); Mon, 16 Mar 2015 19:34:55 -0400 Date: Mon, 16 Mar 2015 16:30:06 -0700 From: Tony Lindgren To: Stefan Hengelein Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux@arm.linux.org.uk, santosh.shilimkar@oracle.com, gregkh@linuxfoundation.org Subject: Re: [PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688 Message-ID: <20150316233005.GA2598@atomide.com> References: <1424889867-8980-1-git-send-email-stefan.hengelein@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424889867-8980-1-git-send-email-stefan.hengelein@fau.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Stefan Hengelein [150225 10:48]: > The Kconfig-Option OMAP4_ERRATA_I688 is never visible due to a > contradiction in it's dependencies. > The option requires ARCH_MULTIPLATFORM to be 'disabled'. However, an > enclosing menu requires either ARCH_MULTI_V6 or ARCH_MULTI_V7 to be > enabled. These options inherit a dependency from an enclosing menu, > that requires ARCH_MULTIPLATFORM to be 'enabled'. > This is a contradiction and made this option also unavailable for > non-multiplatform configurations. > > Since there are no selects on OMAP4_ERRATA_I688, which would ignore > dependencies, the code related to that option is dead and can be > removed. > > This (logical) defect has been found with the undertaker tool. > (https://undertaker.cs.fau.de) > > Signed-off-by: Stefan Hengelein > > --- > Tony Lindgren suggested to remove the code since nobody complained for > a few years and Santosh Shilimkar agreed. > https://lkml.org/lkml/2015/2/25/449 > --- > As far as I see, this should remove all the code related to > OMAP4_ERRATA_I688, I hope I didn't remove too much. Seems to boot fine, so applying into omap-for-v4.1/fixes-not-urgent. Regards, Tony