Re: [PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688

santosh shilimkar
2015-03-17T16:27:42Z

On 3/16/2015 4:30 PM, Tony Lindgren wrote:
> * Stefan Hengelein <stefan.hengelein@fau.de> [150225 10:48]:
>> The Kconfig-Option OMAP4_ERRATA_I688 is never visible due to a
>> contradiction in it's dependencies.
>> The option requires ARCH_MULTIPLATFORM to be 'disabled'. However, an
>> enclosing menu requires either ARCH_MULTI_V6 or ARCH_MULTI_V7 to be
>> enabled. These options inherit a dependency from an enclosing menu,
>> that requires ARCH_MULTIPLATFORM to be 'enabled'.
>> This is a contradiction and made this option also unavailable for
>> non-multiplatform configurations.
>>
>> Since there are no selects on OMAP4_ERRATA_I688, which would ignore
>> dependencies, the code related to that option is dead and can be
>> removed.
>>
>> This (logical) defect has been found with the undertaker tool.
>> (https://undertaker.cs.fau.de)
>>
>> Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de>
>>
>> ---
>> Tony Lindgren suggested to remove the code since nobody complained for
>> a few years and Santosh Shilimkar agreed.
>> https://lkml.org/lkml/2015/2/25/449
>> ---
>> As far as I see, this should remove all the code related to
>> OMAP4_ERRATA_I688, I hope I didn't remove too much.
>
> Seems to boot fine, so applying into omap-for-v4.1/fixes-not-urgent.
>
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>