From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@arm.com>,
linux-kernel@vger.kernel.org,
Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl
Date: Tue, 17 Mar 2015 10:24:23 +0800 [thread overview]
Message-ID: <20150317022423.GB3953@kernel> (raw)
In-Reply-To: <1426231671-12014-1-git-send-email-wanpeng.li@linux.intel.com>
Ping Ingo, ;-)
On Fri, Mar 13, 2015 at 03:27:51PM +0800, Wanpeng Li wrote:
>After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter
>modification handling"), deadline task throttled status is cleared
>each time switch from dl, so throttled status always unset when
>switch back, there is no need to check throttled status, this patch
>drop the check.
>
>Acked-by: Juri Lelli <juri.lelli@arm.com>
>Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>---
> kernel/sched/deadline.c | 8 --------
> 1 file changed, 8 deletions(-)
>
>diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>index 3fa8fa6..5cb5c9c 100644
>--- a/kernel/sched/deadline.c
>+++ b/kernel/sched/deadline.c
>@@ -1659,14 +1659,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
> {
> int check_resched = 1;
>
>- /*
>- * If p is throttled, don't consider the possibility
>- * of preempting rq->curr, the check will be done right
>- * after its runtime will get replenished.
>- */
>- if (unlikely(p->dl.dl_throttled))
>- return;
>-
> if (task_on_rq_queued(p) && rq->curr != p) {
> #ifdef CONFIG_SMP
> if (p->nr_cpus_allowed > 1 && rq->dl.overloaded &&
>--
>1.9.1
next prev parent reply other threads:[~2015-03-17 2:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 7:27 [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl Wanpeng Li
2015-03-17 2:24 ` Wanpeng Li [this message]
2015-03-17 8:08 ` Ingo Molnar
2015-03-17 8:59 ` Wanpeng Li
2015-03-17 9:50 ` Juri Lelli
2015-03-17 9:50 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317022423.GB3953@kernel \
--to=wanpeng.li@linux.intel.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox