From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbbCQCmb (ORCPT ); Mon, 16 Mar 2015 22:42:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:37438 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbbCQCm3 (ORCPT ); Mon, 16 Mar 2015 22:42:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,413,1422950400"; d="scan'208";a="699664030" Date: Tue, 17 Mar 2015 10:24:23 +0800 From: Wanpeng Li To: Ingo Molnar Cc: Peter Zijlstra , Juri Lelli , linux-kernel@vger.kernel.org, Wanpeng Li Subject: Re: [PATCH RESEND] sched/deadline: don't need to check throttled status when switched to dl Message-ID: <20150317022423.GB3953@kernel> Reply-To: Wanpeng Li References: <1426231671-12014-1-git-send-email-wanpeng.li@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426231671-12014-1-git-send-email-wanpeng.li@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping Ingo, ;-) On Fri, Mar 13, 2015 at 03:27:51PM +0800, Wanpeng Li wrote: >After commit 40767b0dc768 ("sched/deadline: Fix deadline parameter >modification handling"), deadline task throttled status is cleared >each time switch from dl, so throttled status always unset when >switch back, there is no need to check throttled status, this patch >drop the check. > >Acked-by: Juri Lelli >Signed-off-by: Wanpeng Li >--- > kernel/sched/deadline.c | 8 -------- > 1 file changed, 8 deletions(-) > >diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c >index 3fa8fa6..5cb5c9c 100644 >--- a/kernel/sched/deadline.c >+++ b/kernel/sched/deadline.c >@@ -1659,14 +1659,6 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) > { > int check_resched = 1; > >- /* >- * If p is throttled, don't consider the possibility >- * of preempting rq->curr, the check will be done right >- * after its runtime will get replenished. >- */ >- if (unlikely(p->dl.dl_throttled)) >- return; >- > if (task_on_rq_queued(p) && rq->curr != p) { > #ifdef CONFIG_SMP > if (p->nr_cpus_allowed > 1 && rq->dl.overloaded && >-- >1.9.1