public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Peter Chen <Peter.Chen@freescale.com>
Cc: nick <xerofoify@gmail.com>, "balbi@ti.com" <balbi@ti.com>,
	"ergei.shtylyov@cogentembedded.com" 
	<ergei.shtylyov@cogentembedded.com>,
	"varkab@cdac.in" <varkab@cdac.in>,
	"yoshihiro.shimoda.uh@renesas.com"
	<yoshihiro.shimoda.uh@renesas.com>,
	"ulrich.hecht@gmail.com" <ulrich.hecht@gmail.com>,
	"takeshi.kihara.df@renesas.com" <takeshi.kihara.df@renesas.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Possible  no longer required cast in the function,usbhs_parse_dt in common.c
Date: Tue, 17 Mar 2015 08:51:28 +0100	[thread overview]
Message-ID: <20150317075128.GA27461@kroah.com> (raw)
In-Reply-To: <BN3PR0301MB08490DB516C5E9EFEEA6BC9481030@BN3PR0301MB0849.namprd03.prod.outlook.com>

On Tue, Mar 17, 2015 at 03:37:42AM +0000, Peter Chen wrote:
>  
> > 
> > Greetings All,
> > I have been getting the below build warnings:
> > drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’:
> > drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to
> > integer of different size [-Wpointer-to-int-cast]
> > dparam->type = of_id ? (u32)of_id->data : 0;
> > After looking into the function I am curious if the hardware is only 32 bit as if
> > the supported hardware for this driver is then this cast is no longer required
> > and I can send in a patch removing it. Furthermore, sorry for the simple
> > question but  I don't have access to the device specs for supported hardware
> > so I though it would be better to ask before I send in patch fixing this issue.
> > Thanks,
> > Nick
> 
> Patch is welcome, there will be comment if it is not suitable.

Sorry, but no, a patch is not welcome from Nick.  You all will note that
Nick is banned from vger.kernel.org and I would recommend that everyone
else on the cc: here also add him to their kill-files.  It will make
your life much easier.

greg k-h

      parent reply	other threads:[~2015-03-17  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <55079FF2.6060201@gmail.com>
2015-03-17  3:37 ` Possible no longer required cast in the function,usbhs_parse_dt in common.c Peter Chen
     [not found]   ` <5507A4B3.1020704@gmail.com>
2015-03-17  3:54     ` Felipe Balbi
     [not found]       ` <5507A5EA.8040509@gmail.com>
2015-03-17  4:13         ` Felipe Balbi
     [not found]         ` <5507A941.6010800@gmail.com>
2015-03-17  4:14           ` Felipe Balbi
2015-03-17  7:51   ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317075128.GA27461@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Peter.Chen@freescale.com \
    --cc=balbi@ti.com \
    --cc=ergei.shtylyov@cogentembedded.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=takeshi.kihara.df@renesas.com \
    --cc=ulrich.hecht@gmail.com \
    --cc=varkab@cdac.in \
    --cc=xerofoify@gmail.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox