From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbbCQHve (ORCPT ); Tue, 17 Mar 2015 03:51:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40790 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbbCQHvc (ORCPT ); Tue, 17 Mar 2015 03:51:32 -0400 Date: Tue, 17 Mar 2015 08:51:28 +0100 From: "gregkh@linuxfoundation.org" To: Peter Chen Cc: nick , "balbi@ti.com" , "ergei.shtylyov@cogentembedded.com" , "varkab@cdac.in" , "yoshihiro.shimoda.uh@renesas.com" , "ulrich.hecht@gmail.com" , "takeshi.kihara.df@renesas.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c Message-ID: <20150317075128.GA27461@kroah.com> References: <55079FF2.6060201@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2015 at 03:37:42AM +0000, Peter Chen wrote: > > > > > Greetings All, > > I have been getting the below build warnings: > > drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’: > > drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to > > integer of different size [-Wpointer-to-int-cast] > > dparam->type = of_id ? (u32)of_id->data : 0; > > After looking into the function I am curious if the hardware is only 32 bit as if > > the supported hardware for this driver is then this cast is no longer required > > and I can send in a patch removing it. Furthermore, sorry for the simple > > question but I don't have access to the device specs for supported hardware > > so I though it would be better to ask before I send in patch fixing this issue. > > Thanks, > > Nick > > Patch is welcome, there will be comment if it is not suitable. Sorry, but no, a patch is not welcome from Nick. You all will note that Nick is banned from vger.kernel.org and I would recommend that everyone else on the cc: here also add him to their kill-files. It will make your life much easier. greg k-h