From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Marek Belisko <marek.belisko@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: ft1000: remove code indention
Date: Tue, 17 Mar 2015 16:43:49 +0530 [thread overview]
Message-ID: <20150317111349.GA3823@sudip-PC> (raw)
In-Reply-To: <20150316153334.GB12113@kroah.com>
On Mon, Mar 16, 2015 at 04:33:34PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Mar 07, 2015 at 10:56:53AM +0530, Sudip Mukherjee wrote:
> > modified the code to keep the logic same but removed some indention.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> >
> > this patch will generate checkpatch warning about line more than 80char,
> > and too many use of tab. but unless the total function is rewrtten it will
> > be difficult to fix that.
> >
> > drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 44 +++++++++++-------------
> > 1 file changed, 21 insertions(+), 23 deletions(-)
>
> I don't see how this looks any better, do you?
well, better in the sense very little indention was fixed and code
which was repeating in if-else if - else was placed in a loop, but a
small if-else was still there for the different delay between retries.
I will see if i can make it more better.
regards
sudip
next prev parent reply other threads:[~2015-03-17 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 5:26 [PATCH 1/2] staging: ft1000: remove unused variables Sudip Mukherjee
2015-03-07 5:26 ` [PATCH 2/2] staging: ft1000: remove code indention Sudip Mukherjee
2015-03-16 15:33 ` Greg Kroah-Hartman
2015-03-17 11:13 ` Sudip Mukherjee [this message]
2015-03-16 15:33 ` [PATCH 1/2] staging: ft1000: remove unused variables Greg KH
2015-03-17 12:52 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317111349.GA3823@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox