From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932240AbbCQMw7 (ORCPT ); Tue, 17 Mar 2015 08:52:59 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:35427 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752814AbbCQMww (ORCPT ); Tue, 17 Mar 2015 08:52:52 -0400 Date: Tue, 17 Mar 2015 18:22:38 +0530 From: Sudip Mukherjee To: Greg KH Cc: Marek Belisko , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: ft1000: remove unused variables Message-ID: <20150317125238.GA4058@sudip-PC> References: <1425706013-8888-1-git-send-email-sudipm.mukherjee@gmail.com> <20150316153302.GA12113@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150316153302.GA12113@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 04:33:02PM +0100, Greg KH wrote: > On Sat, Mar 07, 2015 at 10:56:52AM +0530, Sudip Mukherjee wrote: > > these variables were assigned some values but they were never being > > reused again. > > But some of them should have been checked, right? Or, if no one cares, > fix up the function to not return anything, like for all of the > read_register() calls. > > Please do that instead. but the return value of ft1000_read_register() is being used in some places like card_send_command() or in ft1000_ioctl(). we can use the return value (if error) in the poll() or ioctl() instead of returning -1 or -ENOTTY. but in the other places, its - no one cares. regards sudip > > thanks, > > greg k-h