From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbbCQOGq (ORCPT ); Tue, 17 Mar 2015 10:06:46 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:35281 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752816AbbCQOGl (ORCPT ); Tue, 17 Mar 2015 10:06:41 -0400 Date: Tue, 17 Mar 2015 19:36:34 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: Benjamin Romer , David Kershner , sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: unisys: remove unused variables Message-ID: <20150317140608.GA5084@sudip-PC> References: <1426169661-15142-1-git-send-email-sudipm.mukherjee@gmail.com> <20150316153458.GA12503@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150316153458.GA12503@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 04:34:58PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 12, 2015 at 07:44:20PM +0530, Sudip Mukherjee wrote: > > these variable were being assigned some values but never reused. > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/staging/unisys/virthba/virthba.c | 18 ++++++------------ > > drivers/staging/unisys/virtpci/virtpci.c | 22 +++++++--------------- > > 2 files changed, 13 insertions(+), 27 deletions(-) > > > > diff --git a/drivers/staging/unisys/virthba/virthba.c b/drivers/staging/unisys/virthba/virthba.c > > index e5b0dd8..655db2f 100644 > > --- a/drivers/staging/unisys/virthba/virthba.c > > +++ b/drivers/staging/unisys/virthba/virthba.c > > @@ -333,16 +333,14 @@ static inline void > > send_disk_add_remove(struct diskaddremove *dar) > > { > > struct scsi_device *sdev; > > - int error; > > > > sdev = scsi_device_lookup(dar->shost, dar->channel, dar->id, dar->lun); > > if (sdev) { > > if (!(dar->add)) > > scsi_remove_device(sdev); > > } else if (dar->add) { > > - error = > > - scsi_add_device(dar->shost, dar->channel, dar->id, > > - dar->lun); > > + scsi_add_device(dar->shost, dar->channel, dar->id, > > + dar->lun); > > This should be properly checked, not ignored. i have a total newbie question on this one and I am hoping to get some pointer or some advise on it. this send_disk_add_remove() is being called from do_disk_add_remove() which is a function called from a workqueue. so how do i return error codes fom here? regards sudip