From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754672AbbCRAzO (ORCPT ); Tue, 17 Mar 2015 20:55:14 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:22484 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753500AbbCRAzL (ORCPT ); Tue, 17 Mar 2015 20:55:11 -0400 Date: Tue, 17 Mar 2015 20:55:55 -0400 From: Steven Rostedt To: Xie XiuQi Cc: Tony Luck , Naoya Horiguchi , Chen Gong , Bjorn Helgaas , "Borislav Petkov" , Linux Kernel Mailing List , "linux-mm@kvack.org" , Subject: Re: [PATCH] tracing: add trace event for memory-failure Message-ID: <20150317205555.207b0605@grimm.local.home> In-Reply-To: <5508064C.7090707@huawei.com> References: <1426241451-25729-1-git-send-email-xiexiuqi@huawei.com> <20150313153210.14f1bd88@gandalf.local.home> <5508064C.7090707@huawei.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Mar 2015 18:47:40 +0800 Xie XiuQi wrote: > I'm not clearly why we need a hard coded here. As the strings or "result" have > defined in mm/memory-failure.c, so passing "action_name[result]" would be more > clean and more flexible here? The TP_printk() is what will be shown in the print format of the event "format" file, and is what trace-cmd and perf use to parse the data and know what to print. If you use "action_name[result]" that will be what the user space tools see, and will have no idea what to do with "action_name[result]". The hard coded output is a bit more explicit in how to interpret the raw data. Another way around this is to create a "plugin" that can be loaded and will override the TP_printk() parsing. -- Steve