From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945AbbCSCin (ORCPT ); Wed, 18 Mar 2015 22:38:43 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41477 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbbCSCil (ORCPT ); Wed, 18 Mar 2015 22:38:41 -0400 Date: Wed, 18 Mar 2015 22:38:40 -0400 (EDT) Message-Id: <20150318.223840.2031144211289934113.davem@davemloft.net> To: linux@rainbow-software.org Cc: netdev@vger.kernel.org, bjorn@mork.no, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "net: cx82310_eth: use common match macro" From: David Miller In-Reply-To: <1426716061-20953-1-git-send-email-linux@rainbow-software.org> References: <1426716061-20953-1-git-send-email-linux@rainbow-software.org> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ondrej Zary Date: Wed, 18 Mar 2015 23:01:01 +0100 > This reverts commit 11ad714b98f6d9ca0067568442afe3e70eb94845 because > it breaks cx82310_eth. > > The custom USB_DEVICE_CLASS macro matches > bDeviceClass, bDeviceSubClass and bDeviceProtocol > but the common USB_DEVICE_AND_INTERFACE_INFO matches > bInterfaceClass, bInterfaceSubClass and bInterfaceProtocol instead, which are > not specified. > > Signed-off-by: Ondrej Zary Applied, thank you.