From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756045AbbCRLZX (ORCPT ); Wed, 18 Mar 2015 07:25:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:34775 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754448AbbCRLZV (ORCPT ); Wed, 18 Mar 2015 07:25:21 -0400 Date: Wed, 18 Mar 2015 14:25:09 +0300 From: Dan Carpenter To: Lorenzo Stoakes Cc: Vitaly Kuznetsov , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Teddy Wang , Greg KH , linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Message-ID: <20150318112509.GP10964@mwanda> References: <1426669046-29935-1-git-send-email-lstoakes@gmail.com> <87oanqo9zi.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 11:12:20AM +0000, Lorenzo Stoakes wrote: > On 18 March 2015 at 10:50, Vitaly Kuznetsov wrote: > > ERROR is reported by scripts/checkpatch.pl (spaces are missing after > > ','). This coding style problem was there before your patch but I don't > > think it makes sense to preserve it. > > [snip] > > > WARNING: please, no spaces at the start of a line > > #137: FILE: drivers/staging/sm750fb/sm750.c:833: > > [snip] > > Hi Vitaly, these style issues have vexed me and I was not sure whether > to make changes or preserve all the obvious errors so as not to blend > the two changes inappropriately, however it does indeed make sense to > fix these on the lines I'm changing, will fix these! If it's a white space thing on the same line then it's generally ok to fix it. The "one thing per patch" is meant to make patches easier to review. If it's a trivial thing and it doesn't make it harder to review then we are reasonable people. Could you read your patches again and find other similar white space issues. + void __iomem * pbuffer,*pstart; Should be: + void __iomem *pbuffer, *pstart; regards, dan carpenter