* [PATCH] Staging: dgnc: release the lock before testing for nullity
@ 2015-03-18 12:51 Quentin Lambert
2015-03-18 12:57 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Quentin Lambert @ 2015-03-18 12:51 UTC (permalink / raw)
To: Lidza Louina
Cc: Mark Hounschell, Greg Kroah-Hartman, driverdev-devel, devel,
linux-kernel, kernel-janitors, Quentin Lambert
Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return")
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 8445f84ddaa3..f1c4d07a0aaa 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -656,9 +656,9 @@ void dgnc_input(struct channel_t *ch)
return;
exit_unlock:
+ spin_unlock_irqrestore(&ch->ch_lock, flags);
if (ld)
tty_ldisc_deref(ld);
- spin_unlock_irqrestore(&ch->ch_lock, flags);
}
--
2.3.2.223.g7a9409c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: dgnc: release the lock before testing for nullity
2015-03-18 12:51 [PATCH] Staging: dgnc: release the lock before testing for nullity Quentin Lambert
@ 2015-03-18 12:57 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-03-18 12:57 UTC (permalink / raw)
To: Quentin Lambert
Cc: Lidza Louina, devel, Greg Kroah-Hartman, driverdev-devel,
kernel-janitors, linux-kernel
This patch has no changelog. What's the bug?
On Wed, Mar 18, 2015 at 01:51:52PM +0100, Quentin Lambert wrote:
> Fixes: c84a083b995b ("Staging: dgnc: Use goto for spinlock release before return")
>
Don't put a blank line here.
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-18 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-18 12:51 [PATCH] Staging: dgnc: release the lock before testing for nullity Quentin Lambert
2015-03-18 12:57 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox