From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932981AbbCRN3y (ORCPT ); Wed, 18 Mar 2015 09:29:54 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35820 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755158AbbCRN3w (ORCPT ); Wed, 18 Mar 2015 09:29:52 -0400 Date: Wed, 18 Mar 2015 18:59:41 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Lorenzo Stoakes , Greg KH , linux-kernel@vger.kernel.org, Teddy Wang Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Message-ID: <20150318132941.GA1922@sudip-PC> References: <1426669046-29935-1-git-send-email-lstoakes@gmail.com> <87oanqo9zi.fsf@vitty.brq.redhat.com> <20150318112509.GP10964@mwanda> <20150318130607.GB32758@sudip-PC> <20150318132339.GR10964@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150318132339.GR10964@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote: > > https://lkml.org/lkml/2015/3/10/685 > > > > You were making random white space changes and not on the same line. It > was hard to review because you had to count how many u32 arguments there > were (a million) and really look at it to see what the compile warning > was. There was no compile warning in the end. Very annoying. ok, now understood. Thanks. like you said once - combining different changes in a single patch is an art. :) regards sudip > > regards, > dan carpenter >