From: Greg KH <gregkh@linuxfoundation.org>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH octeon-usb] fix 'line over 80 characters'
Date: Wed, 18 Mar 2015 15:53:40 +0100 [thread overview]
Message-ID: <20150318145340.GA1048@kroah.com> (raw)
In-Reply-To: <20150318144232.GA5973@amitoj-Inspiron-3542>
On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote:
>
> This file contained a warning of a line being over 80 characters and
> so the file has been edited to remove that warning.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Why did you put the driver name within the []? It needs to go outside
of it.
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..c8df0c3 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2884,7 +2884,7 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel)
> pipe->pid_toggle = 1;
> if (__cvmx_usb_pipe_needs_split(usb, pipe))
> transaction->stage =
> - CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;
> + CVMX_USB_STAGE_SETUP_SPLIT_COMPLETE;
This really doesn't help much, the original code is fine, there are
better things to fix in this file :)
thanks,
greg k-h
next prev parent reply other threads:[~2015-03-18 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 14:42 [PATCH octeon-usb] fix 'line over 80 characters' Amitoj Kaur Chawla
2015-03-18 14:53 ` Greg KH [this message]
2015-03-18 18:17 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318145340.GA1048@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amitoj1606@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox